Support scalar subqueries cache #43640
Merged
kitaisreal merged 16 commits intomasterfrom Jan 17, 2023
Merged
Conversation
Implementation: * Added a map with hash of the node (without alias) and the evaluated value to Context. Testing: * Added a test-case with new analyser in 02174_cte_scalar_cache.sql
Member
|
I guess that this being based on query hash, which currently ignores identifier aliases, means the same bugs found in the current interpreter will affect the analyzer. See #31796 (comment) or other tests in #40065 |
…eeNodeTable. Moved cache to QueryAnalysisPass, adjusted test to check with alias - 42648 Support scalar subqueries cache
…rSubqueryIfNeeded - 42648 Support scalar subqueries cache
…upport scalar subqueries cache
…alar subqueries cache
…pport scalar subqueries cache
…42648 Support scalar subqueries cache
…- 42648 Support scalar subqueries cache
kitaisreal
suggested changes
Jan 13, 2023
kitaisreal
approved these changes
Jan 16, 2023
Contributor
|
@SmitaRKulkarni let's wait for tests to pass and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Support scalar subqueries cache
Implementation:
Testing: