Move perf tests for Aarch64 from PRs to master#43623
Conversation
|
AFAIK we use quite powerful (and therefore quite expensive) machines for perf tests. Also seems like it just does not make sense to run perf tests on Aarch64 for each commit in each PR. Perf tests on x86 should be enough to catch performance degradation in 99% of PRs (except some architecture-specific changes). Also almost nobody looks at flaky performance tests, especially on Aarch64.
~110 actually, because most checks in the list are duplicated
It's another major issue. We still have to investigate why clang-tidy build takes more than 5 (FIVE!!!) hours sometimes: https://s3.amazonaws.com/clickhouse-builds/43442/d9975c9d13fd8215706226912dd6bf1c37fd4f77/clickhouse_special_build_check/report.html
Unfortunately, no. Another issue is that we always run only some sample of perf tests. We should run all perf tests (including tests on Aarch64) for PRs labeled as "performance improvement". I'll convert this PR to draft for now. |
Now there is: arm perf tests will start if pr has |
|
About clang-tidy performance: Yes, it's terribly slow in some builds. No new checks were added recently afaik. In my experience, some checks can be much more expensive than others. Unfortunately, there is no good way of finding these except with "bisecting". I am currently doing that locally ... |
Changelog category (leave one):