Skip to content

Add a comment#43403

Merged
alexey-milovidov merged 1 commit intomasterfrom
table-function-add-comment
Nov 21, 2022
Merged

Add a comment#43403
alexey-milovidov merged 1 commit intomasterfrom
table-function-add-comment

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

The PR #42708 - was incomplete - the code was not entirely obvious: #43316 (comment)

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Nov 20, 2022
@SmitaRKulkarni SmitaRKulkarni self-assigned this Nov 21, 2022
Copy link
Copy Markdown
Member

@SmitaRKulkarni SmitaRKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexey-milovidov
Copy link
Copy Markdown
Member Author

#43277

@alexey-milovidov
Copy link
Copy Markdown
Member Author

@SmitaRKulkarni my comment successfully found a potential issue in the code: #43445

@alexey-milovidov alexey-milovidov merged commit bb5756b into master Nov 21, 2022
@alexey-milovidov alexey-milovidov deleted the table-function-add-comment branch November 21, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants