Fix function parameters parsing#43350
Merged
evillique merged 1 commit intoClickHouse:masterfrom Nov 21, 2022
Merged
Conversation
devcrafter
approved these changes
Nov 21, 2022
Member
devcrafter
left a comment
There was a problem hiding this comment.
Compared new and old behavior, - LGTM
In general, I was surprised that we can provide arguments to function as (arg1)(arg2) in addition to usual way (arg1, arg2). Did it come with the new parser, or it's long existing thing?
Member
Author
|
It is a long-existing thing, and actually It is usually used in aggregate functions, for example quantileTiming |
Member
Author
|
AST fuzzer (tsan): #43202 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix a bug that allowed FucntionParser to parse an unlimited amount of round brackets into one function if
allow_function_parametersis set.Also, disable
allow_function_parametersfor table functions in the FROM section of the SELECT query. This fixes #43331