Skip to content

Improve masking sensitive info#43227

Merged
vitlibar merged 13 commits intoClickHouse:masterfrom
vitlibar:improve-masking-sensitive-info
Nov 18, 2022
Merged

Improve masking sensitive info#43227
vitlibar merged 13 commits intoClickHouse:masterfrom
vitlibar:improve-masking-sensitive-info

Conversation

@vitlibar
Copy link
Copy Markdown
Member

@vitlibar vitlibar commented Nov 14, 2022

Changelog category:

  • Improvement

Changelog entry:

Follow-up to #42484. Mask sensitive information in logs better; mask secret parts in the output of queries SHOW CREATE TABLE and SELECT FROM system.tables. Also resolves #41418

@vitlibar vitlibar force-pushed the improve-masking-sensitive-info branch from 0c36967 to 3756e51 Compare November 14, 2022 17:59
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-improvement Pull request with some product improvements label Nov 14, 2022
@vitlibar vitlibar force-pushed the improve-masking-sensitive-info branch from f86854a to 9d02033 Compare November 14, 2022 19:15
@vitlibar
Copy link
Copy Markdown
Member Author

@SmitaRKulkarni do you want to review this PR?

@vitlibar vitlibar force-pushed the improve-masking-sensitive-info branch 2 times, most recently from ed6ce0c to 5095f62 Compare November 14, 2022 20:15
@SmitaRKulkarni SmitaRKulkarni self-assigned this Nov 15, 2022
@vitlibar vitlibar force-pushed the improve-masking-sensitive-info branch from 9b4675a to 63be12a Compare November 16, 2022 00:36
@vitlibar vitlibar force-pushed the improve-masking-sensitive-info branch from bde808c to 794ad1c Compare November 17, 2022 17:14
@vitlibar vitlibar force-pushed the improve-masking-sensitive-info branch from 794ad1c to 86e486d Compare November 17, 2022 17:16
Copy link
Copy Markdown
Member

@SmitaRKulkarni SmitaRKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest all LGTM

@ucasfl
Copy link
Copy Markdown
Collaborator

ucasfl commented Jul 10, 2024

I think for SHOW CREATE query, we should add a setting to control hidden it or not, becuase in some cases, we want to copy SHOW CREATE from one node/cluster, then execute on another node/cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

query_masking_rules not work for exception messages at query_log

4 participants