Skip to content

fix skip_unavailable_shards does not work using s3Cluster table function#43131

Merged
Avogar merged 1 commit intoClickHouse:masterfrom
xiedeyantu:fix_s3cluster_connection_fail
Nov 14, 2022
Merged

fix skip_unavailable_shards does not work using s3Cluster table function#43131
Avogar merged 1 commit intoClickHouse:masterfrom
xiedeyantu:fix_s3cluster_connection_fail

Conversation

@xiedeyantu
Copy link
Copy Markdown
Contributor

@xiedeyantu xiedeyantu commented Nov 10, 2022

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

fix skip_unavailable_shards does not work using s3Cluster table function

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Nov 10, 2022
@evillique evillique added the can be tested Allows running workflows for external contributors label Nov 10, 2022
@evillique
Copy link
Copy Markdown
Member

evillique commented Nov 11, 2022

Is it possible to add a test? For example similar to the ones in tests/integration/test_s3_cluster/test.py?

@xiedeyantu
Copy link
Copy Markdown
Contributor Author

xiedeyantu commented Nov 11, 2022

Is it possible to add a test? For example similar to the ones in tests/integration/test_s3_cluster/test.py?

OK, I add a test later.

@Avogar Avogar self-assigned this Nov 11, 2022
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 11, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@xiedeyantu xiedeyantu force-pushed the fix_s3cluster_connection_fail branch from cee6644 to 5504f3a Compare November 11, 2022 16:04
@Avogar
Copy link
Copy Markdown
Member

Avogar commented Nov 14, 2022 •
edited
Loading

Thanks for the fix! We have similar problem with hdfsCluster, it will be really great if you can fix it too (maybe in a separate PR). But if you don't have time, no problem.

@Avogar Avogar merged commit 386b69a into ClickHouse:master Nov 14, 2022
@xiedeyantu xiedeyantu mentioned this pull request Nov 16, 2022
Merged
@devcrafter devcrafter mentioned this pull request Jun 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Avogar Avogar Avogar approved these changes

Assignees

@Avogar Avogar

Labels

can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xiedeyantu @evillique @CLAassistant @Avogar @robot-clickhouse