Skip to content

Keeper support manually assigning leader#43026

Merged
antonio2368 merged 11 commits intoClickHouse:masterfrom
JackyWoo:keeper_manually_assign_leader
Nov 21, 2022
Merged

Keeper support manually assigning leader#43026
antonio2368 merged 11 commits intoClickHouse:masterfrom
JackyWoo:keeper_manually_assign_leader

Conversation

@JackyWoo
Copy link
Copy Markdown
Contributor

@JackyWoo JackyWoo commented Nov 8, 2022

I need this feature.

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Keeper improvement: Add 4lw command rqld which can manually assign a node as leader.

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-feature Pull request with new product feature label Nov 8, 2022
@antonio2368
Copy link
Copy Markdown
Member

What's the motivation behind this command?

@antonio2368 antonio2368 self-assigned this Nov 8, 2022
@JackyWoo
Copy link
Copy Markdown
Contributor Author

JackyWoo commented Nov 8, 2022

We deploy keeper cluster across two zones and we want to leader reside in the given one.

@antonio2368 antonio2368 added the can be tested Allows running workflows for external contributors label Nov 8, 2022
@JackyWoo JackyWoo force-pushed the keeper_manually_assign_leader branch from e178039 to 9060141 Compare November 8, 2022 10:46
@JackyWoo JackyWoo requested a review from antonio2368 November 9, 2022 06:49
@antonio2368
Copy link
Copy Markdown
Member

The new test is failing.

@robot-ch-test-poll2 robot-ch-test-poll2 added pr-improvement Pull request with some product improvements and removed pr-feature Pull request with new product feature labels Nov 9, 2022
@JackyWoo
Copy link
Copy Markdown
Contributor Author

CI was blocked, maybe because label changed?

@antonio2368
Copy link
Copy Markdown
Member

@JackyWoo did you check the integration test locally?
If it works, it seems we need to increase time even more.

@JackyWoo
Copy link
Copy Markdown
Contributor Author

@antonio2368 Sorry for late reply, tests fixed. The failure was caused for node2 and node3 are configured can not be leader.

@antonio2368 antonio2368 merged commit 3cb202a into ClickHouse:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants