Fix issue 42856 and MaterializedMySQL improvement#42931
Merged
Avogar merged 9 commits intoClickHouse:masterfrom Nov 14, 2022
Merged
Fix issue 42856 and MaterializedMySQL improvement#42931Avogar merged 9 commits intoClickHouse:masterfrom
Avogar merged 9 commits intoClickHouse:masterfrom
Conversation
Member
|
@zzsmdfj please fix style checks |
stigsb
reviewed
Nov 10, 2022
src/Core/MySQL/MySQLReplication.h
Outdated
| QUERY_EVENT_MULTI_TXN_FLAG = 1, | ||
| QUERY_EVENT_XA = 2 | ||
| QUERY_EVENT_XA = 2, | ||
| QUERY_EVENT_OTHER = 3 |
Contributor
There was a problem hiding this comment.
Could you call this QUERY_SAVEPOINT please? We are using that name in our fork (to be merged upstream soon), good to avoid unnecessary naming conflicts :-)
…smdfj/ClickHouse into MaterializedMySQL_improvement_bug_fix
Contributor
Author
done |
…smdfj/ClickHouse into MaterializedMySQL_improvement_bug_fix
Avogar
approved these changes
Nov 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
bugfix： #42856 ignore Mysql binlog SAVEPOINT event.
improvement：