Skip to content

Don't require manual string serialization to set query parameters#41874

Merged
evillique merged 9 commits intoClickHouse:masterfrom
evillique:better-set-params
Nov 21, 2022
Merged

Don't require manual string serialization to set query parameters#41874
evillique merged 9 commits intoClickHouse:masterfrom
evillique:better-set-params

Conversation

@evillique
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

SET param_x query no longer requires manual string serialization for the value of the parameter.
For example, query SET param_a = '[\'a\', \'b\']' can now be written like SET param_a = ['a', 'b'].

Closes #40343.

@robot-ch-test-poll robot-ch-test-poll added the pr-improvement Pull request with some product improvements label Sep 28, 2022
@kssenii kssenii self-assigned this Sep 28, 2022
@evillique
Copy link
Copy Markdown
Member Author

AST Fuzzer - no signs of any error in logs
Other test failures seem to be present in other PRs and not connected to these changes

Copy link
Copy Markdown
Member

@kssenii kssenii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evillique
Copy link
Copy Markdown
Member Author

Test failures are not related.

@evillique evillique merged commit f3c16ec into ClickHouse:master Nov 21, 2022
@evillique evillique deleted the better-set-params branch November 21, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support different types of parameters in interactive sessions

3 participants