increase default max_suspicious_broken_parts to 100#41619
Merged
KochetovNicolai merged 1 commit intoClickHouse:masterfrom Sep 22, 2022
den-crane:patch-50
Merged
increase default max_suspicious_broken_parts to 100#41619KochetovNicolai merged 1 commit intoClickHouse:masterfrom den-crane:patch-50
KochetovNicolai merged 1 commit intoClickHouse:masterfrom
den-crane:patch-50
Conversation
KochetovNicolai
approved these changes
Sep 22, 2022
Contributor
|
@den-crane This setting does not exist in |
Contributor
Author
|
@ramazanpolat select * from system.merge_tree_settings where name like '%max_suspicious_broken_parts%';
┌─name──────────────────────────────┬─value──────┬─changed─┬─description──────────────────────────────────────────────────────┬─type───┐
│ max_suspicious_broken_parts │ 100 │ 0 │ Max broken parts, if more - deny automatic deletion. │ UInt64 │
│ max_suspicious_broken_parts_bytes │ 1073741824 │ 0 │ Max size of all broken parts, if more - deny automatic deletion. │ UInt64 │
└───────────────────────────────────┴────────────┴─────────┴──────────────────────────────────────────────────────────────────┴────────┘ |
This was referenced Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #41423
We often see complaints about startup issue
Suspiciously many (12 parts, 0.00 B in total) broken parts to remove while maximum allowed broken parts count is 10and in 100% cases it's because of an unexpected restart and files with 0 size or parts without half of files. The maximum number that I saw in public chats or from Altinity clients is 70 broken parts.(it seems the modern hardware (ssd) + arbitrary partitioning allow to create a more parts per second than it was in 2016 when max_suspicious_broken_parts = 10 was good enough)
Personally I set max_suspicious_broken_parts = 100.
Anyway this behaviour is secured by
max_suspicious_broken_parts_bytes │ 1073741824Changelog category (leave one):