Fix WriteBuffer finalize in destructor when cancel query#39396
Merged
Avogar merged 1 commit intoClickHouse:masterfrom Jul 20, 2022
Merged
Fix WriteBuffer finalize in destructor when cancel query#39396Avogar merged 1 commit intoClickHouse:masterfrom
Avogar merged 1 commit intoClickHouse:masterfrom
Conversation
Member
Author
|
I will create a separate PR soon where I will try to get rid of finalize in destructors and see what will happen |
kitaisreal
approved these changes
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix WriteBuffer finalize in destructor when cacnel query that could lead to stuck query or even terminate. Closes #38199