Skip to content

Fire and clean windows in WindowView only when data is inserted#37853

Merged
kssenii merged 3 commits intoClickHouse:masterfrom
Vxider:fire-when-inserted
Jun 7, 2022
Merged

Fire and clean windows in WindowView only when data is inserted#37853
kssenii merged 3 commits intoClickHouse:masterfrom
Vxider:fire-when-inserted

Conversation

@Vxider
Copy link
Copy Markdown
Contributor

@Vxider Vxider commented Jun 4, 2022

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fire and clean windows in WindowView only when data is inserted, avoid the table not found exception caused by fire() when the database is not fully started.

might fix #37665 (comment)

Detail changes:

  1. the workload of cleaning outdated data is triggered by fire() instead of a timer.
  2. in event time processing, fire() is triggered by data insert
  3. in process time processing, fire() is triggered only when there is unfired data.

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 4, 2022
@kssenii kssenii self-assigned this Jun 5, 2022
@kssenii kssenii added the can be tested Allows running workflows for external contributors label Jun 5, 2022
@kssenii
Copy link
Copy Markdown
Member

kssenii commented Jun 6, 2022

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 6, 2022

update

✅ Branch has been successfully updated

@kssenii kssenii merged commit edc6b68 into ClickHouse:master Jun 7, 2022
@Vxider Vxider deleted the fire-when-inserted branch June 7, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StorageWindowView fails to start sometimes

3 participants