Fire and clean windows in WindowView only when data is inserted#37853
Merged
kssenii merged 3 commits intoClickHouse:masterfrom Jun 7, 2022
Merged
Fire and clean windows in WindowView only when data is inserted#37853kssenii merged 3 commits intoClickHouse:masterfrom
kssenii merged 3 commits intoClickHouse:masterfrom
Conversation
kssenii
approved these changes
Jun 5, 2022
Member
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fire and clean windows in WindowView only when data is inserted, avoid the
table not found exceptioncaused byfire()when the database is not fully started.might fix #37665 (comment)
Detail changes:
fire()is triggered by data insertfire()is triggered only when there is unfired data.