Skip to content

libunwind update version#37797

Merged
kitaisreal merged 7 commits intoClickHouse:masterfrom
kitaisreal:libunwind-update-version
Jun 15, 2022
Merged

libunwind update version#37797
kitaisreal merged 7 commits intoClickHouse:masterfrom
kitaisreal:libunwind-update-version

Conversation

@kitaisreal
Copy link
Copy Markdown
Contributor

@kitaisreal kitaisreal commented Jun 2, 2022

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix stacktraces collection on ARM. Closes #37044. Closes #15638.

@robot-ch-test-poll robot-ch-test-poll added pr-improvement Pull request with some product improvements submodule changed At least one submodule changed in this PR. labels Jun 2, 2022
@kitaisreal kitaisreal added the can be tested Allows running workflows for external contributors label Jun 2, 2022
@kitaisreal
Copy link
Copy Markdown
Contributor Author

kitaisreal commented Jun 2, 2022

Before:

WITH arrayMap(x -> demangle(addressToSymbol(x)), trace) AS all SELECT thread_name, thread_id, query_id, arrayStringConcat(all, '\n') AS res FROM system.stack_trace LIMIT 1 FORMAT Vertical;
Row 1:
──────
thread_name: clickhouse-serv
thread_id:   74055
query_id:    
res:         StackTrace::StackTrace(ucontext_t const&)
DB::(anonymous namespace)::signalHandler(int, siginfo_t*, void*)

1 row in set. Elapsed: 0.010 sec.

After:

WITH arrayMap(x -> demangle(addressToSymbol(x)), trace) AS all SELECT thread_name, thread_id, query_id, arrayStringConcat(all, '\n') AS res FROM system.stack_trace LIMIT 1 FORMAT Vertical;
Row 1:
──────
thread_name: clickhouse-serv
thread_id:   63670
query_id:    
res:         pthread_cond_wait@@GLIBC_2.17
std::__1::condition_variable::wait(std::__1::unique_lock<std::__1::mutex>&)
BaseDaemon::waitForTerminationRequest()
DB::Server::main(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&)
Poco::Util::Application::run()
DB::Server::run()
Poco::Util::ServerApplication::run(int, char**)
mainEntryClickHouseServer(int, char**)
main
__libc_start_main

1 row in set. Elapsed: 0.031 sec

@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Jun 5, 2022

Did you incorporate the patches for libunwind?

@alexey-milovidov alexey-milovidov self-assigned this Jun 5, 2022
@alexey-milovidov alexey-milovidov marked this pull request as draft June 5, 2022 12:05
@kitaisreal kitaisreal force-pushed the libunwind-update-version branch 2 times, most recently from b54f0ae to 09ba4fa Compare June 10, 2022 16:36
@kitaisreal kitaisreal force-pushed the libunwind-update-version branch from b73f1b8 to fb54a1c Compare June 13, 2022 09:44
@kitaisreal kitaisreal marked this pull request as ready for review June 15, 2022 09:03
@nikitamikhaylov
Copy link
Copy Markdown
Member

nikitamikhaylov commented Jun 15, 2022

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 15, 2022

update

✅ Branch has been successfully updated

@kitaisreal kitaisreal merged commit 5729210 into ClickHouse:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexey-milovidov alexey-milovidov

Labels

can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No stack unwinding on ARM64 Clickhouse on ARM spams libunwind: Unsupported .eh_frame_hdr version to the stdout

4 participants

@kitaisreal @alexey-milovidov @nikitamikhaylov @robot-ch-test-poll