Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ alexey-milovidov
✅ zhanglistar
❌ listar

macOS does not have fdatasync.

Improve performance of syncing data to block device

@zhanglistar do you have any performance numbers for this change? I think that the difference for MergeTree code for example (where we write the whole file and only after this calling sync) should be negligible.

Improve performance of syncing data to block device

@zhanglistar do you have any performance numbers for this change? I think that the difference for MergeTree code for example (where we write the whole file and only after this calling sync) should be negligible.

@azat In the clickhouse-keeper code, I try to use fdatasync instead of fsync, the writing performance increase about 30%.
Here is the detail:
keeper + fsync:

keeper + fdatasync:

And there is a conversation about this in the end of pr:
#23038