Ignore "file changed as we read it" error for integration tests artifacts#28220
Closed
azat wants to merge 1 commit intoClickHouse:masterfrom
Closed
Ignore "file changed as we read it" error for integration tests artifacts#28220azat wants to merge 1 commit intoClickHouse:masterfrom
azat wants to merge 1 commit intoClickHouse:masterfrom
Conversation
…acts
CI reported failure [1]:
...
tar: test_mysql_database_engine/_instances_0/node1/database/store/a9e/a9e3fd27-b61c-4239-a9e3-fd27b61c2239: file changed as we read it
[1]: https://clickhouse-test-reports.s3.yandex.net/28213/91621cfcd2bf83e71931697ae1de9a1b3abdfa14/integration_tests_(release).html#fail1
And we cannot be sure that there are no clickhouse-service alive since
restart/cleanup of old containers will happens only after the test group
will run.
alesapin
approved these changes
Aug 27, 2021
Member
|
Actually not so good, but will fix the issue. |
Member
Author
Indeed. Need to take a closer look how to shutdown containers properly before tar. |
Member
Author
|
It can be fixed by moving container cleanup after running tests, but anyway there should be no containers after tests had been finished. |
Member
Author
|
Actually maybe it should be reopened, since in case of such errors you will not get the artifacts, while it is required for the investigation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI reported failure 1:
And we cannot be sure that there are no clickhouse-service alive since
restart/cleanup of old containers will happens only after the test group
will run.
Changelog category (leave one):