Fix UB in FunctionArrayElement::executeGenericConst(...)#19336
Closed
Fix UB in FunctionArrayElement::executeGenericConst(...)#19336
Conversation
Member
|
@tavplubix I've made another fix in #19347. It looks more complete. |
| else if (index.getType() == Field::Types::Int64) | ||
| ArrayElementGenericImpl::vectorConst<true>( | ||
| col_nested, col_array->getOffsets(), -safeGet<Int64>(index) - 1, *col_res, builder); | ||
| col_nested, col_array->getOffsets(), -(safeGet<Int64>(index) + 1), *col_res, builder); |
Member
There was a problem hiding this comment.
It still has signed integer overflow when index is max positive Int64.
Member
Author
There was a problem hiding this comment.
If I understand correctly, this branch is executed only when index is negative (we call ArrayElementGenericImpl::vectorConst(...) with negative = true), so there is no signed integer overflow.
Member
|
Please review my PR then :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Detailed description / Documentation draft:
https://clickhouse-test-reports.s3.yandex.net/19091/0507a38ec639e5eeba78f020ff2fc2d3d3447a0d/fuzzer_ubsan/report.html#fail1
Fixes #19305