Fix integrity check#18871
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom Jan 8, 2021
Merged
Conversation
This will also fix integrity check (ClickHouse#18811), the reason it does not pops up on CI during PR testing because CI does not set YANDEX_OFFICIAL_BUILD, while it does set it for commits merged into upstream commits, and hence once it was merged the special build was failed. Follow-up for: ClickHouse#16366
Follow-up for: ClickHouse#18811 Refs: ClickHouse#18785
alexey-milovidov
approved these changes
Jan 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The reason that it wasn't pops up during testing PR #18811 on CI, because runs for PRs does not set YANDEX_OFFICIAL_BUILD, while runs for merged into upstream commits does.
P.S. this PR contains two separate patches, because I did not want to waste more CPU time on CI
Cc: @alexey-milovidov
Follow-up-for: #16366
Follow-up-for: #18811