Add explicit main_configs, user_configs and dictionaries in integration tests#13647
Merged
vitlibar merged 34 commits intoClickHouse:masterfrom Sep 4, 2020
Merged
Add explicit main_configs, user_configs and dictionaries in integration tests#13647vitlibar merged 34 commits intoClickHouse:masterfrom
vitlibar merged 34 commits intoClickHouse:masterfrom
Conversation
vitlibar
reviewed
Aug 14, 2020
vitlibar
reviewed
Aug 14, 2020
vitlibar
reviewed
Aug 14, 2020
…o integration-explicit-configs
vitlibar
reviewed
Sep 4, 2020
| node3 = cluster.add_instance('node3', config_dir="configs", main_configs=['configs/remote_servers.xml', 'configs/log_conf.xml'], with_zookeeper=True) | ||
| node4 = cluster.add_instance('node4', config_dir="configs", main_configs=['configs/remote_servers.xml', 'configs/log_conf.xml'], with_zookeeper=True) | ||
| node5 = cluster.add_instance('node5', config_dir="configs", main_configs=['configs/remote_servers.xml', 'configs/log_conf.xml'], with_zookeeper=True) | ||
| node3 = cluster.add_instance('node3', user_configs=[], main_configs=['configs/remote_servers.xml', 'configs/log_conf.xml'], with_zookeeper=True) |
Member
There was a problem hiding this comment.
user_configs=[] is default value, isn't it?
Member
There was a problem hiding this comment.
Then could you remove user_configs=[] here and in other places where cluster.add_instance() is called?
Member
There was a problem hiding this comment.
And main_configs=[] as well. Just to make the code shorter.
vitlibar
reviewed
Sep 4, 2020
| self.ignore_error = ignore_error | ||
|
|
||
| #print " ".join(command) | ||
| print " ".join(command) |
Member
There was a problem hiding this comment.
Why did you uncomment this line and other print lines?
vitlibar
reviewed
Sep 4, 2020
| </structure> | ||
| </dictionary> | ||
| </dictionaries> | ||
| </yandex> No newline at end of file |
Member
There was a problem hiding this comment.
Minor: it's better to add an empty line at the end of the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Integration tests use default base config. All config changes are explicit with main_configs, user_configs and dictionaries parameters for instance.
Detailed description / Documentation draft:
Splitted a part of large PR #10484 to separate one
By adding documentation, you'll allow users to try your new feature immediately, not when someone else will have time to document it later. Documentation is necessary for all features that affect user experience in any way. You can add brief documentation draft above, or add documentation right into your patch as Markdown files in docs folder.
If you are doing this for the first time, it's recommended to read the lightweight Contributing to ClickHouse Documentation guide first.