Skip to content

Fix arrayJoin with GROUP BY#13625

Closed
azat wants to merge 2 commits intoClickHouse:masterfrom
azat:totals-chunk-assertion
Closed

Fix arrayJoin with GROUP BY#13625
azat wants to merge 2 commits intoClickHouse:masterfrom
azat:totals-chunk-assertion

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Aug 11, 2020

TODO: update Changelog category to Bugfix

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix arrayJoin with GROUP BY

Found with: AST query fuzzer
Blocked by: #13611

@alexey-milovidov
Copy link
Copy Markdown
Member

But it should not happen. It indicates a bug, so "logical error".

@azat azat marked this pull request as draft August 11, 2020 22:02
@azat
Copy link
Copy Markdown
Member Author

azat commented Aug 13, 2020

But it should not happen. It indicates a bug, so "logical error".

@alexey-milovidov Indeed this is an error, looks like the problem is that SELECT arrayJoin([[], []]), * FROM numbers(1) GROUP BY number should fail with NOT_AN_AGGREGATE, thoughts?

Right now this PR is blocked by #13611 (since it touches the same bits and maybe it will address them)

@azat azat changed the title Introduce INVALID_TOTALS_BLOCK instead of LOGICAL_ERROR for TOTALS block with multiple rows Fix arrayJoin with GROUP BY Aug 13, 2020
@azat azat force-pushed the totals-chunk-assertion branch from f0d0137 to 9a0249c Compare August 13, 2020 20:48
@azat azat force-pushed the totals-chunk-assertion branch from 9a0249c to 24ca9af Compare August 13, 2020 20:48
@azat azat closed this Sep 3, 2020
@azat azat deleted the totals-chunk-assertion branch September 9, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants