Workflow [PR], commit [67a66cd]

Summary: ❌

AI Review

Summary

This PR updates fiber/MSan integration by enabling BOOST_USE_MSAN for _boost_context, updating the Boost submodule to a commit that adds proper MSan fiber-switch hooks, and removing local __msan_unpoison from FiberStack::allocate. The change is small, targeted, and consistent with upstream sanitizer integration; I did not find correctness, safety, or performance issues in the touched paths.

Missing context

• ⚠️ No CI report links or run results were provided in this review context, so runtime validation under MSan could not be verified here.

ClickHouse Rules

Final Verdict

• Status: ✅ Approve

So either it is a problem in other places, or it is not mandatory

Though the example from LLVM clearly reproduce a bug, though it has manual assertion - https://github.com/llvm/llvm-project/blob/main/compiler-rt/test/msan/Linux/swapcontext_annotation.cpp

# with __msan* commented out
$ clang -fsanitize-memory-use-after-dtor -fsanitize-memory-track-origins -fsanitize=memory -o /tmp/test compiler-rt/test/msan/Linux/swapcontext_annotation.cpp
$ /tmp/test
main: swapcontext to fiber
fiber: entering fiber
test: compiler-rt/test/msan/Linux/swapcontext_annotation.cpp:27: void (anonymous namespace)::fiber(): Assertion `previous_stack_bottom != nullptr' failed.
Aborted                    /tmp/test

LLVM Coverage Report

Changed lines: 100.00% (3/3) · Uncovered code

Full report · Diff report

Though actually I'm not sure that this will fix the problem