Skip to content

tests: attempt to fix test_overcommit_tracker flakiness under amd_llvm_coverage#101270

Merged
azat merged 1 commit intoClickHouse:masterfrom
azat:tests/test_overcommit_tracker
Mar 31, 2026
Merged

tests: attempt to fix test_overcommit_tracker flakiness under amd_llvm_coverage#101270
azat merged 1 commit intoClickHouse:masterfrom
azat:tests/test_overcommit_tracker

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Mar 30, 2026 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

With new proper asserition added in #100621 the test fails for amd_llvm_coverage, let's try something obvious - FORMAT Null, if this won't help, we can play with settings/parallelism

Fixes: #101318

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 30, 2026 •
edited
Loading

Workflow [PR], commit [12bef2a]

Summary: ✅

AI Review

Summary

This PR makes test_overcommit_tracker less flaky by removing a node-level thread soft-limit override and applying per-query max_threads=1 directly in both competing queries. I did not find a high-confidence correctness, safety, or performance issue in the current PR head that warrants a new inline comment.

ClickHouse Rules
Item Status Notes
Deletion logging ➖
Serialization versioning ➖
Core-area scrutiny ➖
No test removal ✅
Experimental gate ➖
No magic constants ✅
Backward compatibility ✅
SettingsChangesHistory.cpp ➖
PR metadata quality ✅
Safe rollout ✅
Compilation time ✅
Final Verdict
  • Status: ✅ Approve

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 30, 2026
This was referenced Mar 30, 2026
Merged
Closed
Merged
clickhouse-gh[bot]
clickhouse-gh bot reviewed Mar 30, 2026
View reviewed changes
@azat azat force-pushed the tests/test_overcommit_tracker branch from ebafca1 to f23ad1a Compare March 30, 2026 20:24
@alexey-milovidov alexey-milovidov self-assigned this Mar 30, 2026
@azat azat enabled auto-merge March 30, 2026 20:54
@azat azat mentioned this pull request Mar 31, 2026
Merged
@kssenii kssenii mentioned this pull request Mar 31, 2026
Merged
1 task
@JiaQiTang98 JiaQiTang98 mentioned this pull request Mar 31, 2026
Open
1 task
@nickitat nickitat linked an issue Mar 31, 2026 that may be closed by this pull request
Flaky test: test_overcommit_tracker #101318
Open
@azat azat force-pushed the tests/test_overcommit_tracker branch from f23ad1a to 12bef2a Compare March 31, 2026 14:45
@azat azat added this pull request to the merge queue Mar 31, 2026
Merged via the queue into ClickHouse:master with commit 64eb660 Mar 31, 2026
164 checks passed
@azat azat deleted the tests/test_overcommit_tracker branch March 31, 2026 23:40
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 31, 2026
@antaljanosbenjamin antaljanosbenjamin mentioned this pull request Apr 1, 2026
Merged
1 task
@rienath rienath mentioned this pull request Apr 1, 2026
Open
@antaljanosbenjamin antaljanosbenjamin mentioned this pull request Apr 1, 2026
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clickhouse-gh clickhouse-gh[bot] clickhouse-gh[bot] left review comments

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flaky test: test_overcommit_tracker

3 participants

@azat @alexey-milovidov @robot-clickhouse-ci-1