Add engine-specific icons for tables in Play UI sidebar#101126
Closed
alexey-milovidov wants to merge 3 commits intomasterfrom
Closed
Add engine-specific icons for tables in Play UI sidebar#101126alexey-milovidov wants to merge 3 commits intomasterfrom
alexey-milovidov wants to merge 3 commits intomasterfrom
Conversation
Each table in the sidebar now shows an SVG icon to the left of its name, reflecting the table engine: - MergeTree family: table grid icon - `SummingMergeTree`/`AggregatingMergeTree`: capital sigma (Σ) - `Memory`: microchip - `View`: eye - `MaterializedView`: eye over table lines - `Merge`: three overlaid tables - `Distributed`: fanout (box with arrows to three boxes) - `Proxy`: arrow between two boxes Replicated and Shared prefixes are stripped before matching. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Workflow [PR], commit [3403121] Summary: ❌
AI ReviewSummaryThis PR adds engine-specific SVG icons in ClickHouse Rules
Final Verdict
|
…e_function` The test expected `StorageProxy` as the engine name, but the PR renamed it to `Proxy`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The engine `StorageProxy` reports itself as `StorageProxy` (not `Proxy`). Fix the icon matching in play.html and revert the test reference to the correct engine name. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each table in the sidebar now shows an SVG icon to the left of its name, reflecting the table engine:
SummingMergeTree/AggregatingMergeTree: capital sigma (Σ)Memory: microchipView: eyeMaterializedView: eye over table linesMerge: three overlaid tablesDistributed: fanout (box with arrows to three boxes)Proxy: arrow between two boxesReplicated and Shared prefixes are stripped before matching. Icons are inline SVGs using
currentColorso they adapt to both light and dark themes.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Show engine-specific icons next to table names in the Play UI sidebar.
Documentation entry for user-facing changes