Skip to content

Add test for OR conditions in JOIN ON and IS NOT DISTINCT FROM#100972

Open
alexey-milovidov wants to merge 13 commits intomasterfrom
add-test-join-on-or-is-not-distinct-from
Open

Add test for OR conditions in JOIN ON and IS NOT DISTINCT FROM#100972
alexey-milovidov wants to merge 13 commits intomasterfrom
add-test-join-on-or-is-not-distinct-from

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Mar 27, 2026

Add a test verifying that all three SQL patterns from #40976 now work correctly:

  1. OR conditions in JOIN ON clause
  2. IS NOT DISTINCT FROM in JOIN ON clause
  3. Tuple IS NOT DISTINCT FROM in JOIN ON clause

Closes #40976

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@alexey-milovidov @claude
Add test for OR conditions in JOIN ON and IS NOT DISTINCT FROM
79aa9f3 
All three SQL patterns from #40976
now work correctly:
1. OR conditions in JOIN ON clause
2. IS NOT DISTINCT FROM in JOIN ON clause
3. Tuple IS NOT DISTINCT FROM in JOIN ON clause

Closes #40976

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 27, 2026 •
edited
Loading

Workflow [PR], commit [4a107f9]

Summary: ❌

job_name test_name status info comment
Stress test (amd_debug) failure
Logical error: Shard number is greater than shard count: shard_num=A shard_count=B cluster=C (STID: 5066-457d) FAIL cidb

AI Review

Summary

This PR adds a new stateless regression test (04064_join_on_or_is_not_distinct_from) for issue #40976, covering OR predicates in JOIN ON, scalar IS NOT DISTINCT FROM, and tuple IS NOT DISTINCT FROM, and enables the analyzer explicitly for the test. The change is test-only, focused, and aligned with the reported bug scope.

ClickHouse Rules
Item Status Notes
Deletion logging ➖
Serialization versioning ➖
Core-area scrutiny ✅
No test removal ✅
Experimental gate ➖
No magic constants ✅
Backward compatibility ✅
SettingsChangesHistory.cpp ➖
PR metadata quality ✅
Safe rollout ✅
Compilation time ✅
Final Verdict
  • Status: ✅ Approve

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 27, 2026
alexey-milovidov and others added 8 commits March 28, 2026 02:15
@alexey-milovidov
Merge branch 'master' into add-test-join-on-or-is-not-distinct-from
ea922ec
@alexey-milovidov
Merge remote-tracking branch 'origin/master' into add-test-join-on-or…
c1e2101 
…-is-not-distinct-from
@alexey-milovidov @claude
Fix test: add SET enable_analyzer = 1 and rename to avoid number co…
ab0a4f9 
…nflict

The test uses OR conditions in JOIN ON which are only supported by the
new analyzer. Add `SET enable_analyzer = 1` so it passes in old-analyzer
CI configurations. Also rename from 04063 to 04064 to avoid conflict
with 04063_in_subquery_lowcardinality_tuple_key merged to master.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@alexey-milovidov
Merge branch 'master' into add-test-join-on-or-is-not-distinct-from
1952fe2
@alexey-milovidov
Merge remote-tracking branch 'origin/master' into add-test-join-on-or…
7be852e 
…-is-not-distinct-from
@alexey-milovidov
Merge remote-tracking branch 'origin/master' into add-test-join-on-or…
dabfeb5 
…-is-not-distinct-from
@alexey-milovidov
Merge remote-tracking branch 'origin/master' into add-test-join-on-or…
94b01cb 
…-is-not-distinct-from
@alexey-milovidov
Merge remote-tracking branch 'origin/master' into add-test-join-on-or…
8d156c4 
…-is-not-distinct-from
@groeneai groeneai mentioned this pull request Mar 30, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Invalid JOIN_ON condition

1 participant

@alexey-milovidov