Add startup warning when mdraid is being resynchronized#100941
Open
alexey-milovidov wants to merge 9 commits intomasterfrom
Open
Add startup warning when mdraid is being resynchronized#100941alexey-milovidov wants to merge 9 commits intomasterfrom
alexey-milovidov wants to merge 9 commits intomasterfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Workflow [PR], commit [ae900cb] Summary: ❌
AI ReviewSummaryThis PR adds Linux ClickHouse Rules
Final Verdict
|
azat
reviewed
Mar 27, 2026
azat
reviewed
Mar 27, 2026
…load for `addOrUpdateWarningMessage` - Check `/sys/block/mdX/md/array_state` in addition to `sync_action` to warn when an mdraid array is in a non-normal state (degraded, inactive, etc.) - Add `addOrUpdateWarningMessage` overload accepting `std::optional<PreformattedMessage>`: passing `nullopt` removes the warning, enabling future periodic checks to automatically clear stale warnings when conditions resolve. - New warning type `LINUX_MDRAID_IS_DEGRADED`. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…y_state` values These are valid non-degraded states for read-only arrays, so we should not warn about them. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
LLVM Coverage Report
Changed lines: 50.00% (31/62) · Uncovered code |
azat
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a startup sanity check that warns when any Linux mdraid array is currently being checked, repaired, or resynchronized. This can significantly degrade disk I/O performance and is useful to know about when diagnosing slow queries or merges.
The check iterates over
/sys/block/md*/md/sync_actionand warns if the action is anything other thanidle.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Add a startup warning (visible in
system.warnings) when a Linux mdraid array is being resynchronized, as this can degrade disk I/O performance.Documentation entry for user-facing changes