Skip to content

Update cppkafka to include fix for Consumer close deadlock#100612

Merged
azat merged 1 commit intoClickHouse:masterfrom
azat:kafka-drop-hung-fix
Mar 24, 2026
Merged

Update cppkafka to include fix for Consumer close deadlock#100612
azat merged 1 commit intoClickHouse:masterfrom
azat:kafka-drop-hung-fix

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Mar 24, 2026 •
edited
Loading

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Update cppkafka to include fix for Consumer close deadlock

Refs: #11145
Refs: ClickHouse/cppkafka#6
Fixes: #100511

@azat azat requested a review from antaljanosbenjamin March 24, 2026 14:43
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 24, 2026 •
edited
Loading

Workflow [PR], commit [9ee87d3]

Summary: ✅

AI Review

Summary

This PR updates contrib/cppkafka from 0403eb3 to 99ee856 to pick up an upstream fix for a Consumer shutdown deadlock. I reviewed the full upstream delta behind the submodule bump (not just the submodule pointer line) and found no actionable correctness, lifetime, concurrency, or performance regressions in the imported changes. The destructor change intentionally switches to a non-throwing destroy path via rd_kafka_destroy_flags, which is consistent with safe cleanup semantics.

ClickHouse Rules
Item Status Notes
Deletion logging ➖
Serialization versioning ➖
Core-area scrutiny ✅
No test removal ✅
Experimental gate ➖
No magic constants ✅
Backward compatibility ✅
SettingsChangesHistory.cpp ➖
PR metadata quality ✅
Safe rollout ✅
Compilation time ✅
Final Verdict
  • Status: ✅ Approve

@clickhouse-gh clickhouse-gh bot added pr-improvement Pull request with some product improvements submodule changed At least one submodule changed in this PR. labels Mar 24, 2026
@Ergus Ergus self-assigned this Mar 24, 2026
@azat azat mentioned this pull request Mar 24, 2026
Closed
@azat azat enabled auto-merge March 24, 2026 15:38
@azat azat added this pull request to the merge queue Mar 24, 2026
Merged via the queue into ClickHouse:master with commit 1dfb403 Mar 24, 2026
152 checks passed
@azat azat deleted the kafka-drop-hung-fix branch March 24, 2026 19:54
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ergus Ergus Ergus approved these changes

@antaljanosbenjamin antaljanosbenjamin Awaiting requested review from antaljanosbenjamin

Assignees

@Ergus Ergus

Labels

pr-improvement Pull request with some product improvements pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DROP TABLE kafka may hang in librdkafka (flaky test_storage_kafka)

3 participants

@azat @Ergus @robot-ch-test-poll4