comments

arthurpassos · arthurpassos · commit ffc88fd8a32f · 2024-10-30T21:53:53.000-03:00
diff --git a/src/Parsers/Access/ParserCreateUserQuery.cpp b/src/Parsers/Access/ParserCreateUserQuery.cpp
@@ -657,9 +657,9 @@ bool ParserCreateUserQuery::parseImpl(Pos & pos, ASTPtr & node, Expected & expec
     else if (alter)
         names->concatParts();
 
-    bool alter_command_with_no_changes = alter && pos_after_parsing_names == pos;
+    bool alter_query_with_no_changes = alter && pos_after_parsing_names == pos;
 
-    if (alter_command_with_no_changes)
+    if (alter_query_with_no_changes)
     {
         return false;
     }
diff --git a/tests/queries/0_stateless/03254_test_alter_user_no_changes.sql b/tests/queries/0_stateless/03254_test_alter_user_no_changes.sql
@@ -2,3 +2,4 @@
 
 create user u_03254_alter_user;
 alter user u_03254_alter_user; -- { clientError SYNTAX_ERROR }
+drop user u_03254_alter_user;

Original file line number	Diff line number	Diff line change
`@@ -657,9 +657,9 @@ bool ParserCreateUserQuery::parseImpl(Pos & pos, ASTPtr & node, Expected & expec`
`657`	`657`	`else if (alter)`
`658`	`658`	`names->concatParts();`
`659`	`659`
`660`		`- bool alter_command_with_no_changes = alter && pos_after_parsing_names == pos;`
	`660`	`+ bool alter_query_with_no_changes = alter && pos_after_parsing_names == pos;`
`661`	`661`
`662`		`- if (alter_command_with_no_changes)`
	`662`	`+ if (alter_query_with_no_changes)`
`663`	`663`	`{`
`664`	`664`	`return false;`
`665`	`665`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,3 +2,4 @@`
`2`	`2`
`3`	`3`	`create user u_03254_alter_user;`
`4`	`4`	`alter user u_03254_alter_user; -- { clientError SYNTAX_ERROR }`
	`5`	`+drop user u_03254_alter_user;`