Backport #78858 to 25.3: Fix crash in REFRESHABLE MV in case of ALTER after incorrect shutdown

robot-clickhouse · robot-clickhouse · commit 9df8be5a5f7b · 2025-04-10T06:13:22.000Z
diff --git a/src/Storages/MaterializedView/RefreshTask.cpp b/src/Storages/MaterializedView/RefreshTask.cpp
@@ -207,6 +207,8 @@ void RefreshTask::checkAlterIsPossible(const DB::ASTRefreshStrategy & new_strate
 
 void RefreshTask::alterRefreshParams(const DB::ASTRefreshStrategy & new_strategy)
 {
+    StorageID view_storage_id = StorageID::createEmpty();
+
     {
         std::lock_guard guard(mutex);
 
@@ -225,9 +227,17 @@ void RefreshTask::alterRefreshParams(const DB::ASTRefreshStrategy & new_strategy
         refresh_settings = {};
         if (new_strategy.settings != nullptr)
             refresh_settings.applyChanges(new_strategy.settings->changes);
+
+        if (view)
+            view_storage_id = view->getStorageID();
     }
+
     /// In case refresh period changed.
-    view->getContext()->getRefreshSet().notifyDependents(view->getStorageID());
+    if (view_storage_id)
+    {
+        const auto & refresh_set = Context::getGlobalContextInstance()->getRefreshSet();
+        refresh_set.notifyDependents(view_storage_id);
+    }
 }
 
 RefreshTask::Info RefreshTask::getInfo() const

Original file line number	Diff line number	Diff line change
`@@ -207,6 +207,8 @@ void RefreshTask::checkAlterIsPossible(const DB::ASTRefreshStrategy & new_strate`
`207`	`207`
`208`	`208`	`void RefreshTask::alterRefreshParams(const DB::ASTRefreshStrategy & new_strategy)`
`209`	`209`	`{`
	`210`	`+ StorageID view_storage_id = StorageID::createEmpty();`
	`211`	`+`
`210`	`212`	`{`
`211`	`213`	`std::lock_guard guard(mutex);`
`212`	`214`
`@@ -225,9 +227,17 @@ void RefreshTask::alterRefreshParams(const DB::ASTRefreshStrategy & new_strategy`
`225`	`227`	`refresh_settings = {};`
`226`	`228`	`if (new_strategy.settings != nullptr)`
`227`	`229`	`refresh_settings.applyChanges(new_strategy.settings->changes);`
	`230`	`+`
	`231`	`+ if (view)`
	`232`	`+ view_storage_id = view->getStorageID();`
`228`	`233`	`}`
	`234`	`+`
`229`	`235`	`/// In case refresh period changed.`
`230`		`- view->getContext()->getRefreshSet().notifyDependents(view->getStorageID());`
	`236`	`+ if (view_storage_id)`
	`237`	`+ {`
	`238`	`+ const auto & refresh_set = Context::getGlobalContextInstance()->getRefreshSet();`
	`239`	`+ refresh_set.notifyDependents(view_storage_id);`
	`240`	`+ }`
`231`	`241`	`}`
`232`	`242`
`233`	`243`	`RefreshTask::Info RefreshTask::getInfo() const`