Fixed idiotic error in system.parts

alexey-milovidov · alexey-milovidov · commit 99aa5cce3895 · 2019-08-20T03:49:58.000+03:00
diff --git a/dbms/src/Storages/System/StorageSystemPartsBase.cpp b/dbms/src/Storages/System/StorageSystemPartsBase.cpp
@@ -148,10 +148,9 @@ StoragesInfoStream::StoragesInfoStream(const SelectQueryInfo & query_info, const
 
 StoragesInfo StoragesInfoStream::next()
 {
-    StoragesInfo info;
-
     while (next_row < rows)
     {
+        StoragesInfo info;
 
         info.database = (*database_column)[next_row].get<String>();
         info.table = (*table_column)[next_row].get<String>();
@@ -198,10 +197,10 @@ StoragesInfo StoragesInfoStream::next()
         if (!info.data)
             throw Exception("Unknown engine " + info.engine, ErrorCodes::LOGICAL_ERROR);
 
-        break;
+        return info;
     }
 
-    return info;
+    return {};
 }
 
 BlockInputStreams StorageSystemPartsBase::read(

Original file line number	Diff line number	Diff line change
`@@ -148,10 +148,9 @@ StoragesInfoStream::StoragesInfoStream(const SelectQueryInfo & query_info, const`
`148`	`148`
`149`	`149`	`StoragesInfo StoragesInfoStream::next()`
`150`	`150`	`{`
`151`		`- StoragesInfo info;`
`152`		`-`
`153`	`151`	`while (next_row < rows)`
`154`	`152`	`{`
	`153`	`+ StoragesInfo info;`
`155`	`154`
`156`	`155`	`info.database = (*database_column)[next_row].get<String>();`
`157`	`156`	`info.table = (*table_column)[next_row].get<String>();`
`@@ -198,10 +197,10 @@ StoragesInfo StoragesInfoStream::next()`
`198`	`197`	`if (!info.data)`
`199`	`198`	`throw Exception("Unknown engine " + info.engine, ErrorCodes::LOGICAL_ERROR);`
`200`	`199`
`201`		`- break;`
	`200`	`+ return info;`
`202`	`201`	`}`
`203`	`202`
`204`		`- return info;`
	`203`	`+ return {};`
`205`	`204`	`}`
`206`	`205`
`207`	`206`	`BlockInputStreams StorageSystemPartsBase::read(`