Fix bool literals in generated SettingsData constructor

Algunenano · claude · Algunenano · commit 5bafb822bdc6 · 2026-03-31T12:11:56.000+02:00
The generator emitted `SettingFieldBool(0)` / `SettingFieldBool(1)` for
obsolete settings defined with `MAKE_OBSOLETE(M, Bool, name, 0)`.
clang-tidy requires `true`/`false` literals instead.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/src/Core/gen_settings_data.sh b/src/Core/gen_settings_data.sh
@@ -93,6 +93,11 @@ echo "{"
 for TYPE in "${TYPE_ORDER[@]}"; do
     IDX=0
     while IFS=$'\t' read -r NAME DEFAULT; do
+        ## clang-tidy requires bool literals, not 0/1
+        if [[ "$TYPE" == "Bool" ]]; then
+            [[ "$DEFAULT" == "0" ]] && DEFAULT="false"
+            [[ "$DEFAULT" == "1" ]] && DEFAULT="true"
+        fi
         echo "    ${TYPE}_[${IDX}] = SettingField${TYPE}(${DEFAULT});"
         IDX=$((IDX + 1))
     done < "$TMPDIR/$TYPE.txt"
