Backport #78247 to 24.8: Fix a logical error for function transform

robot-clickhouse · robot-clickhouse · commit 419ef2b206a6 · 2025-04-23T14:12:39.000Z
diff --git a/src/Functions/transform.cpp b/src/Functions/transform.cpp
@@ -150,14 +150,14 @@ namespace
             ColumnPtr default_non_const;
             if (!cache.default_column && arguments.size() == 4)
             {
-                default_non_const = castColumn(arguments[3], result_type);
-                if (in->size() > default_non_const->size())
+                if (arguments[1].column.get()->size() > arguments[3].column.get()->size() || arguments[2].column.get()->size() > arguments[3].column.get()->size())
                 {
                     throw Exception(
-                        ErrorCodes::LOGICAL_ERROR,
-                        "Fourth argument of function {} must be a constant or a column at least as big as the second and third arguments",
+                        ErrorCodes::BAD_ARGUMENTS,
+                        "Fourth argument of function {} must be a constant or at least as big as the second and third arguments",
                         getName());
                 }
+                default_non_const = castColumn(arguments[3], result_type);
             }
 
             ColumnPtr in_casted = arguments[0].column;
diff --git a/tests/queries/0_stateless/03340_transform_logical_error_fix.reference b/tests/queries/0_stateless/03340_transform_logical_error_fix.reference
diff --git a/tests/queries/0_stateless/03340_transform_logical_error_fix.sql b/tests/queries/0_stateless/03340_transform_logical_error_fix.sql
@@ -0,0 +1,7 @@
+SET enable_analyzer = 1;
+
+SELECT transform(NULL, ['', ''], ['', ''], *)
+FROM
+(
+    SELECT NULL
+); -- { serverError BAD_ARGUMENTS }

Original file line number	Diff line number	Diff line change
`@@ -150,14 +150,14 @@ namespace`
`150`	`150`	`ColumnPtr default_non_const;`
`151`	`151`	`if (!cache.default_column && arguments.size() == 4)`
`152`	`152`	`{`
`153`		`- default_non_const = castColumn(arguments[3], result_type);`
`154`		`- if (in->size() > default_non_const->size())`
	`153`	`+ if (arguments[1].column.get()->size() > arguments[3].column.get()->size() \|\| arguments[2].column.get()->size() > arguments[3].column.get()->size())`
`155`	`154`	`{`
`156`	`155`	`throw Exception(`
`157`		`- ErrorCodes::LOGICAL_ERROR,`
`158`		`- "Fourth argument of function {} must be a constant or a column at least as big as the second and third arguments",`
	`156`	`+ ErrorCodes::BAD_ARGUMENTS,`
	`157`	`+ "Fourth argument of function {} must be a constant or at least as big as the second and third arguments",`
`159`	`158`	`getName());`
`160`	`159`	`}`
	`160`	`+ default_non_const = castColumn(arguments[3], result_type);`
`161`	`161`	`}`
`162`	`162`
`163`	`163`	`ColumnPtr in_casted = arguments[0].column;`