Fix crash in :CachedOnDiskReadBufferFromFile dtor

shankar-iyer · shankar-iyer · commit 39e41c4cc82f · 2026-03-09T10:12:27.000Z
diff --git a/src/Disks/IO/CachedOnDiskReadBufferFromFile.cpp b/src/Disks/IO/CachedOnDiskReadBufferFromFile.cpp
@@ -666,7 +666,7 @@ bool CachedOnDiskReadBufferFromFile::completeFileSegmentAndGetNext()
 
 CachedOnDiskReadBufferFromFile::~CachedOnDiskReadBufferFromFile()
 {
-    if (cache_log && info.file_segments && !info.file_segments->empty())
+    if (cache_log && info.file_segments && !info.file_segments->empty() && state)
     {
         appendFilesystemCacheLog(info.file_segments->front(), state->read_type);
     }

Original file line number	Diff line number	Diff line change
`@@ -666,7 +666,7 @@ bool CachedOnDiskReadBufferFromFile::completeFileSegmentAndGetNext()`
`666`	`666`
`667`	`667`	`CachedOnDiskReadBufferFromFile::~CachedOnDiskReadBufferFromFile()`
`668`	`668`	`{`
`669`		`- if (cache_log && info.file_segments && !info.file_segments->empty())`
	`669`	`+ if (cache_log && info.file_segments && !info.file_segments->empty() && state)`
`670`	`670`	`{`
`671`	`671`	`appendFilesystemCacheLog(info.file_segments->front(), state->read_type);`
`672`	`672`	`}`