Merge pull request #60419 from Avogar/fix-ub-setting

Avogar · web-flow · commit 2e4de1f5e83d · 2024-02-28T13:32:39.000+01:00
Fix undefined-behavior in case of too big max_execution_time setting
diff --git a/src/Core/SettingsFields.cpp b/src/Core/SettingsFields.cpp
@@ -21,6 +21,7 @@ namespace ErrorCodes
     extern const int CANNOT_PARSE_BOOL;
     extern const int CANNOT_PARSE_NUMBER;
     extern const int CANNOT_CONVERT_TYPE;
+    extern const int BAD_ARGUMENTS;
 }
 
 
@@ -268,6 +269,10 @@ namespace
         if (d != 0.0 && !std::isnormal(d))
             throw Exception(
                 ErrorCodes::CANNOT_PARSE_NUMBER, "A setting's value in seconds must be a normal floating point number or zero. Got {}", d);
+        if (d * 1000000 > std::numeric_limits<Poco::Timespan::TimeDiff>::max() || d * 1000000 < std::numeric_limits<Poco::Timespan::TimeDiff>::min())
+            throw Exception(
+                ErrorCodes::BAD_ARGUMENTS, "Cannot convert seconds to microseconds: the setting's value in seconds is too big: {}", d);
+
         return static_cast<Poco::Timespan::TimeDiff>(d * 1000000);
     }
 
diff --git a/tests/queries/0_stateless/03000_too_big_max_execution_time_setting.reference b/tests/queries/0_stateless/03000_too_big_max_execution_time_setting.reference
diff --git a/tests/queries/0_stateless/03000_too_big_max_execution_time_setting.sql b/tests/queries/0_stateless/03000_too_big_max_execution_time_setting.sql
@@ -0,0 +1,2 @@
+select 1 settings max_execution_time = 9223372036854775808; -- {clientError BAD_ARGUMENTS}
+

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+select 1 settings max_execution_time = 9223372036854775808; -- {clientError BAD_ARGUMENTS}`
	`2`	`+`