Skip to content

Fix Seeker failing in dry run mode#601

Merged
Flaminel merged 1 commit into
mainfrom
fix_seeker_dry_run
May 4, 2026
Merged

Fix Seeker failing in dry run mode#601
Flaminel merged 1 commit into
mainfrom
fix_seeker_dry_run

Conversation

@Flaminel

@Flaminel Flaminel commented May 4, 2026

Copy link
Copy Markdown
Contributor

Relates to #600

Summary by Sourcery

Bug Fixes:

  • Prevent Arr item search from failing by returning a default result when dry-run mode is enabled.

@Flaminel

Flaminel commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

@sourcery-ai review

@sourcery-ai

sourcery-ai Bot commented May 4, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts ArrClient.SearchItemAsync to handle dry-run mode by returning a safe default when no IDs are found, preventing failures in dry runs.

Class diagram for updated ArrClient SearchItemAsync behavior

classDiagram
    class ArrClient {
        +Task~long~ SearchItemAsync(ArrInstance arrInstance, SearchItem item)
    }

    class DryRunInterceptor {
        +Task~bool~ IsDryRunEnabled()
    }

    class ArrInstance
    class SearchItem

    ArrClient --> DryRunInterceptor : uses

    note for ArrClient "SearchItemAsync now checks dry run and returns FirstOrDefault when IsDryRunEnabled is true"
Loading

File-Level Changes

Change Details Files
Update single-item search to be tolerant of empty search results during dry-run mode.
  • Call SearchItemsAsync as before to get the list of IDs for the search item.
  • In dry-run mode, return the first ID if present, or 0 if no IDs are found using FirstOrDefault.
  • Keep non-dry-run behavior unchanged by still returning the first ID and throwing if the sequence is empty.
code/backend/Cleanuparr.Infrastructure/Features/Arr/ArrClient.cs

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • In SearchItemAsync, returning ids.FirstOrDefault() in dry-run mode changes the behavior from throwing on empty results to silently returning 0; consider either keeping behavior consistent (still failing when no IDs are found) or adding a brief inline comment explaining why a default 0 is acceptable in dry-run to avoid masking unexpected empty results.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `SearchItemAsync`, returning `ids.FirstOrDefault()` in dry-run mode changes the behavior from throwing on empty results to silently returning 0; consider either keeping behavior consistent (still failing when no IDs are found) or adding a brief inline comment explaining why a default 0 is acceptable in dry-run to avoid masking unexpected empty results.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov

codecov Bot commented May 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...leanuparr.Infrastructure/Features/Arr/ArrClient.cs 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Flaminel Flaminel merged commit 3553fce into main May 4, 2026
13 of 14 checks passed
@Flaminel Flaminel deleted the fix_seeker_dry_run branch May 4, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant