@sourcery-ai review

Codecov Report

❌ Patch coverage is 58.64662% with 55 lines in your changes missing coverage. Please review.

📢 Thoughts on this report? Let us know!

@greptileai review

Greptile Summary

This PR adds a SearchItemGrabbed notification event that fires when a completed Seeker search results in a download being grabbed. It also refactors SeekerCommandMonitor from batch-per-event tracker processing to one-tracker-per-search, removes the now-redundant item_type column from seeker_command_trackers, and adds the new event flag across all 7 notification providers (UI + backend + migration).

• The new SearchItemAsync wrapper in ArrClient calls ids.First() on the result of SearchItemsAsync, which will throw InvalidOperationException if the list is empty. The old code had an explicit guard (if (commandIds.Count == 0) return;) that handled this gracefully; the new path propagates an exception to the callers' catch blocks instead.

Confidence Score: 4/5

Safe to merge after addressing the ids.First() throw on empty list in SearchItemAsync

The overall feature is well-structured and consistently applied across all layers, but ArrClient.SearchItemAsync removes the previous empty-list guard and calls ids.First() unconditionally. While the outer try/catch prevents a crash, it changes graceful no-op behavior to an exception, and the intent of the old guard suggests empty-list returns were considered a real possibility.

code/backend/Cleanuparr.Infrastructure/Features/Arr/ArrClient.cs (empty-list handling) and code/backend/Cleanuparr.Infrastructure/Features/Jobs/SeekerCommandMonitor.cs (early return skips orphaned terminal trackers)

Important Files Changed

Sequence Diagram

sequenceDiagram
    participant S as Seeker
    participant AC as ArrClient
    participant EP as EventPublisher
    participant DB as DataContext
    participant SCM as SeekerCommandMonitor
    participant NP as NotificationPublisher

    S->>AC: SearchItemAsync(instance, item)
    AC->>AC: SearchItemsAsync([item])
    AC-->>S: commandId (long)
    S->>EP: PublishSearchTriggered(title, type, reason)
    EP-->>S: eventId (Guid)
    S->>DB: SeekerCommandTrackers.Add(tracker)

    Note over SCM: Background poll (every 15s)
    SCM->>AC: GetCommandStatusAsync(instance, commandId)
    AC-->>SCM: ArrCommandStatus
    SCM->>DB: tracker.Status = Completed
    SCM->>AC: GetQueueItemsAsync(instance, page 1)
    AC-->>SCM: QueueListResponse (grabbed items)
    SCM->>EP: PublishSearchCompleted(eventId, Completed, instanceType, url, grabbedItems)
    EP->>DB: Update SearchEventData.GrabbedItems
    EP->>NP: NotifySearchItemGrabbed(title, items, type, url)
    NP-->>NP: SendNotificationAsync(SearchItemGrabbed, context)
    SCM->>DB: SeekerCommandTrackers.Remove(tracker)

_{Reviews (1): Last reviewed commit: "added db migration" | Re-trigger Greptile}