Add a floating button for the back menu by bonelag · Pull Request #217 · ClassicOldSong/moonlight-android

bonelag · 2025-05-17T07:13:39Z

My pull request

ClassicOldSong · 2025-05-17T07:18:33Z

Thank you , but if you try compile, it won't work. Please fix the above reviews.

bonelag · 2025-05-17T07:25:40Z

Screenrecorder-2025-05-17-14-24-57-234.mp4

it work😅

ClassicOldSong · 2025-05-17T07:27:41Z

It won't work if you use the latest code. Just try compile the branch you're sending the PR from.

bonelag · 2025-05-17T07:30:19Z

The version I tested is an older version than the current one, but the logic is still the same. I hope you can refer to it and apply it in the latest version.

ClassicOldSong · 2025-05-17T07:32:54Z

Yes, but I have modified parts in a recent commit there that you removed. Please add them back.

bonelag · 2025-05-17T07:36:27Z

I don't quite understand what you mean, can you be more specific so I can provide what you need?

ClassicOldSong · 2025-05-17T07:15:56Z

app/src/main/java/com/limelight/Game.java

    public static final String EXTRA_PORT = "Port";
    public static final String EXTRA_HTTPS_PORT = "HttpsPort";
    public static final String EXTRA_APP_NAME = "AppName";
-    public static final String EXTRA_APP_UUID = "AppUUID";


Please don't remove the newly added parts.......

ClassicOldSong · 2025-05-17T07:16:05Z

app/src/main/java/com/limelight/Game.java


    public static final String CLIPBOARD_IDENTIFIER = "ArtemisStreaming";

-    private String appUUID;


ClassicOldSong · 2025-05-17T07:16:14Z

app/src/main/java/com/limelight/Game.java

        host = Game.this.getIntent().getStringExtra(EXTRA_HOST);
        port = Game.this.getIntent().getIntExtra(EXTRA_PORT, NvHTTP.DEFAULT_HTTP_PORT);
        httpsPort = Game.this.getIntent().getIntExtra(EXTRA_HTTPS_PORT, 0); // 0 is treated as unknown
-        appUUID = Game.this.getIntent().getStringExtra(EXTRA_APP_UUID);


ClassicOldSong · 2025-05-17T07:16:25Z

app/src/main/java/com/limelight/Game.java

        byte[] derCertData = Game.this.getIntent().getByteArrayExtra(EXTRA_SERVER_CERT);

-        app = new NvApp(appName != null ? appName : "app", appUUID, appId, appSupportsHdr);
+        app = new NvApp(appName != null ? appName : "app", appId, appSupportsHdr);


ClassicOldSong · 2025-05-17T07:16:33Z

app/src/main/java/com/limelight/Game.java

                .setVirtualDisplay(vDisplay)
                .setResolutionScaleFactor(prefConfig.resolutionScaleFactor)
                .setApp(app)
-                .setEnableUltraLowLatency(prefConfig.enableUltraLowLatency)


ClassicOldSong · 2025-05-17T07:39:23Z

Ah sorry, I didn't submit the reviews

bonelag · 2025-05-17T07:43:30Z

oh i see, i copied and pasted the code of the old version so it caused an error, i will review it

ClassicOldSong

Also, can we add a preference option to toggle the floating button? If it can be toggled in the back menu dynamically it's even better.

ClassicOldSong · 2025-05-17T08:01:32Z

app/src/main/java/com/limelight/Game.java

+    private float dX, dY;
+    private boolean isMovingButton = false;
+    private static final float CLICK_ACTION_THRESHOLD = 5;
+    private float startX, startY;


Class member names should reflect what they're actually for. dX/dY, startX/startY are just too generic.

Also here, please change them to a more specific name.

ClassicOldSong · 2025-05-17T08:03:09Z

app/src/main/java/com/limelight/Game.java

+                            newX = getWindow().getDecorView().getWidth() - view.getWidth();
+                        }
+                        if (newY > getWindow().getDecorView().getHeight() - view.getHeight()) {
+                            newY = getWindow().getDecorView().getHeight() - view.getHeight();


The same value can be stored in a local variable, no need to get and calcuoate them everytime. The original Moonlight code did this but let's keep this bad habbit out of our new codes.

bonelag

since I'm not very good at coding I merged it with the back menu's hide/show setting

bonelag · 2025-05-17T08:13:46Z

app/src/main/java/com/limelight/Game.java

        streamView.setClipToOutline(true);
    }
-}
+    private void updateFloatingButtonVisibility() {


since I'm not very good at coding I merged it with the back menu hide/show setting

bonelag · 2025-05-17T08:18:08Z

I tested it because I needed to use it, so it's not very professional. If you have any ideas for changes, just do it to upgrade the app to be more complete.

ClassicOldSong · 2025-05-17T09:28:31Z

README.md

 Artemis is currently the best fork of Moonlight with loads of optimizations for office usage.

-A more seamless experience with virtual display will be Artemis paired with [Apollo](https://github.com/ClassicOldSong/Apollo).
+A more seamless experience with virtual display will be Artemis paired with [Artemis](https://github.com/ClassicOldSong/Artemis).


Artemis paired with Artemis 🤣

It should remain Apollo, and all of the followings.

haha i was a little confused

Here this is still not fixed. You can just revert the edits to this file.

ClassicOldSong · 2025-05-17T11:50:27Z

It seems you have messed up all the Vietnamese translations... You got Apollo and Artemis swapped everywhere. I don't understand Vietnamese so you have to fix it yourself.

ClassicOldSong · 2025-05-18T09:48:04Z

Any updates?

bonelag · 2025-05-18T09:58:48Z

i will fix this now

ClassicOldSong · 2025-05-18T10:09:44Z

README.md

 Artemis is currently the best fork of Moonlight with loads of optimizations for office usage.

-A more seamless experience with virtual display will be Artemis paired with [Apollo](https://github.com/ClassicOldSong/Apollo).
+A more seamless experience with virtual display will be Artemis paired with [Artemis](https://github.com/ClassicOldSong/Artemis).


Here this is still not fixed. You can just revert the edits to this file.

ClassicOldSong · 2025-05-18T10:10:01Z

app/src/main/java/com/limelight/Game.java

+    private float dX, dY;
+    private boolean isMovingButton = false;
+    private static final float CLICK_ACTION_THRESHOLD = 5;
+    private float startX, startY;


Also here, please change them to a more specific name.

ClassicOldSong · 2025-05-18T10:17:27Z

.github/workflows/build.yml

Please don't add CI yet... It causes sign key change and will force everyone to reinstall.

I just build to find bugs, please ignore it

ClassicOldSong · 2025-05-18T10:18:19Z

Please discuss first if you're adding anything, or I'll only cherry picking relvant commits.

ClassicOldSong · 2025-05-18T10:36:30Z

You can build locally to test, no need to rely on the CI and constantly push any minor changes.

bonelag · 2025-05-18T11:00:41Z

i want to do that too but my pc is really bad

bonelag · 2025-05-18T11:00:58Z

ClassicOldSong · 2025-05-18T11:03:25Z

😢

bonelag · 2025-05-18T11:04:58Z

I will try running on android studio cloud

bonelag · 2025-05-18T11:32:32Z

haha I actually control my real machine through a virtual machine

test

0f23f01

bonelag mentioned this pull request May 17, 2025

[Feature request]: Update adds more features #216

Closed

ClassicOldSong reviewed May 17, 2025

View reviewed changes

fix

43bed64

ClassicOldSong requested changes May 17, 2025

View reviewed changes

ClassicOldSong changed the title ~~test~~ Add a floating button for the back menu May 17, 2025

bonelag commented May 17, 2025

View reviewed changes

bonelag added 3 commits May 17, 2025 15:21

Complete Vietnamese translation

7a67568

change RGPClient to Apollo ^_^

ab05c29

:v

90e0da5

ClassicOldSong requested changes May 17, 2025

View reviewed changes

bonelag added 2 commits May 18, 2025 17:07

fix trans

772e44b

fix readme

13ce696

ClassicOldSong requested changes May 18, 2025

View reviewed changes

bonelag added 4 commits May 18, 2025 17:11

auto build

db2313c

build

1a757aa

auto build

261ce6e

build

6b5198b

fix auto build

b5631a0

ClassicOldSong requested changes May 18, 2025

View reviewed changes

bonelag added 4 commits May 18, 2025 17:21

fix 'Found item String/quick_menu_title more than one time'

9c05904

copy author's readme.md

1a3a700

fix

591f5bb

fix

ba72194

ClassicOldSong merged commit 33aa14b into ClassicOldSong:moonlight-noir May 21, 2025


		public static final String CLIPBOARD_IDENTIFIER = "ArtemisStreaming";

		private String appUUID;

Conversation

bonelag commented May 17, 2025

Uh oh!

ClassicOldSong commented May 17, 2025

Uh oh!

bonelag commented May 17, 2025

Uh oh!

ClassicOldSong commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bonelag commented May 17, 2025

Uh oh!

ClassicOldSong commented May 17, 2025

Uh oh!

bonelag commented May 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ClassicOldSong commented May 17, 2025

Uh oh!

bonelag commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ClassicOldSong left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bonelag left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bonelag commented May 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ClassicOldSong commented May 17, 2025

Uh oh!

ClassicOldSong commented May 18, 2025

Uh oh!

bonelag commented May 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ClassicOldSong commented May 18, 2025

Uh oh!

ClassicOldSong commented May 18, 2025

Uh oh!

bonelag commented May 18, 2025

Uh oh!

bonelag commented May 18, 2025

Uh oh!

ClassicOldSong commented May 18, 2025

Uh oh!

bonelag commented May 18, 2025

Uh oh!

bonelag commented May 18, 2025

ClassicOldSong commented May 17, 2025 •

edited

Loading

bonelag commented May 17, 2025 •

edited

Loading