Feature: Added option to disable rumble on controllers from the Apollo side#886
Merged
ClassicOldSong merged 2 commits intoClassicOldSong:masterfrom Jul 13, 2025
Conversation
Added option to disable rumble from the Apollo side
Owner
|
I think we might better inverting the toggle, making it "Enable Rumble" and make it enabled by default... The reversed logic is a pain to deal with. |
Change logic to enable/disable rumble functionality instead of enable block rumble functionality
Contributor
Author
|
Changed the logic to enable/disable rumble functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Added option to disable rumble on controllers from the Apollo side
Use case:
Some users do not always like the rumble functionality and it can interfere with their game play. Disabling the rumble function on a case-by-case system/phone/game/etc basis can be difficult especially for non-technical users or trying to quickly set things up.
Feature:
In the Configuration->Input tab, there is the option to block the rumble functionality. The default is to not disable this functionality (i.e. false). Essentially nothing is done in the rumble() function when it is blocked (i.e. enabled/true).