Skip to content

Enhancement #811 for C++ #812

Merged
10 commits merged intoCiscoDevNet:masterfrom
ygorelik:master
Jul 25, 2018
Merged

Enhancement #811 for C++ #812
10 commits merged intoCiscoDevNet:masterfrom
ygorelik:master

Conversation

@ygorelik
Copy link
Copy Markdown
Collaborator

@ygorelik ygorelik commented Jul 23, 2018

Enhancement #811 for C++.
Introduced Codec feature to decode multiple JSON payload.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 23, 2018 •
edited
Loading

Codecov Report

Merging #812 into master will increase coverage by 0.01%.
The diff coverage is 86.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
+ Coverage   81.04%   81.06%   +0.01%     
==========================================
  Files         171      171              
  Lines       17155    17231      +76     
  Branches     1542     1542              
==========================================
+ Hits        13904    13968      +64     
- Misses       2866     2878      +12     
  Partials      385      385
Impacted Files Coverage Δ
sdk/cpp/core/src/types.hpp 94.11% <ø> (ø) ⬆️
sdk/cpp/core/src/path_api.hpp 71.42% <ø> (ø) ⬆️
sdk/cpp/core/tests/test_entity.cpp 83.2% <100%> (+1.22%) ⬆️
sdk/cpp/core/tests/test_codec.cpp 100% <100%> (ø) ⬆️
sdk/cpp/core/src/netconf_service.cpp 77.15% <55.55%> (-3.17%) ⬇️
sdk/cpp/core/src/crud_service.cpp 89.41% <88.23%> (-0.37%) ⬇️
sdk/cpp/core/src/value_list.cpp 60.98% <88.88%> (+3.06%) ⬆️
sdk/cpp/core/src/path/path.cpp 84.3% <90.9%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8101d9b...5e9daae. Read the comment docs.

@ghost
Copy link
Copy Markdown

ghost commented Jul 23, 2018

Thanks, @ygorelik . Can you please address the codacy issues (https://app.codacy.com/app/ydk/ydk-gen/pullRequest?prid=1937292)?

ghost
ghost suggested changes Jul 23, 2018
View reviewed changes
Copy link
Copy Markdown

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://app.codacy.com/app/ydk/ydk-gen/pullRequest?prid=1937292

@ygorelik
Copy link
Copy Markdown
Collaborator Author

ygorelik commented Jul 24, 2018

Added ylist enhancement for Go accompanied with new test cases and documentation.

@ghost ghost merged commit 456804d into CiscoDevNet:master Jul 25, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ygorelik