Fix yang case when two containers with same name , but different name…#640
Fix yang case when two containers with same name , but different name…#6404 commits merged intomasterfrom unknown repository
Conversation
…spaces, augment one container * Fix golang naming to be consistent with other langs * Updated samples and tests * address #535 * Add more debug msgs and throw exceptions to avoid segfaults * tcp server start/stop
Codecov Report
@@ Coverage Diff @@
## master #640 +/- ##
=======================================
Coverage 32.77% 32.77%
=======================================
Files 31 31
Lines 5450 5450
Branches 550 550
=======================================
Hits 1786 1786
Misses 3664 3664
Continue to review full report at Codecov.
|
| CHECK_NOTHROW(provider.get_encoding()); | ||
| } | ||
|
|
||
| TEST_CASE("CreateNoRepoPTCP") |
There was a problem hiding this comment.
Leave comment about running this test case
| using namespace std; | ||
| #define NC_VERB_VERBOSE 2 | ||
|
|
||
| TEST_CASE("tcp_xr") |
There was a problem hiding this comment.
Same as above: leave a comment about running these test cases
| @@ -0,0 +1,36 @@ | |||
| ## Running Go Samples | |||
There was a problem hiding this comment.
Thanks for creating this read me
sdk/go/core/ydk/path/path.go
Outdated
| panicOnCStateError(cstate) | ||
|
|
||
| if rootSchema == nil { | ||
| ydk.YLogError("root schema is nil!") |
There was a problem hiding this comment.
These new lines are using spaces, but the go files seem to be using tabs.
I believe python style guides recommend spaces and go style guides recommend tabs... Maybe it might be good to commit to one style for the whole project at some point in the future, but for now and for this commit, I think it's better to not mix them up.
ydkgen/printer/go/module_printer.py
Outdated
| self.ctx.writeln('func init() {') | ||
| self.ctx.lvl_inc() | ||
| self.ctx.writeln('fmt.Println("Registering top level entities for package {}")'.format(package.name)) | ||
| #self.ctx.writeln('fmt.Println("Registering top level entities for package {}")'.format(package.name)) |
There was a problem hiding this comment.
Did you mean to delete this line?
| self.ctx.bline() | ||
|
|
||
|
|
||
| def _get_qualified_yang_name(clazz): |
There was a problem hiding this comment.
I think you forgot to delete this
| if child.is_many: | ||
| self._print_many(child) | ||
| else: | ||
| path = '' |
There was a problem hiding this comment.
leave a comment on this code
…spaces, augment one container