add keybase authentication option in netconf provider#619
Merged
3 commits merged intoCiscoDevNet:masterfrom Nov 9, 2017
Merged
add keybase authentication option in netconf provider#6193 commits merged intoCiscoDevNet:masterfrom
3 commits merged intoCiscoDevNet:masterfrom
Conversation
Contributor
ylil93
commented
Nov 6, 2017
- add keybase authentication option in netconf provider
- update testing
- update documentation
- add keybase authentication option in netconf provider - update testing - update documentation
Codecov Report
@@ Coverage Diff @@
## master #619 +/- ##
==========================================
+ Coverage 73.27% 73.35% +0.08%
==========================================
Files 104 105 +1
Lines 10351 10386 +35
Branches 1449 1450 +1
==========================================
+ Hits 7585 7619 +34
Misses 2488 2488
- Partials 278 279 +1
Continue to review full report at Codecov.
|
ghost
suggested changes
Nov 6, 2017
ghost
left a comment
There was a problem hiding this comment.
Thanks for this change, Lily! Just have a few minor comments.
Also, can you please address the codacy review: https://www.codacy.com/app/ydk/ydk-gen/pullRequest?prid=1050462&/login
| :param repo: Reference to an instance of :cpp:class:`Repository<ydk::path::Repository>` | ||
| :param address: IP address of the device supporting a netconf interface. | ||
| :param username: Username to log in to the device. | ||
| :param private_key_path: Path to private key file. |
There was a problem hiding this comment.
Can you indicate if this is the absolute path or relative path?
Contributor
Author
There was a problem hiding this comment.
I've tried both and it takes either, but yeah I can specify that.
| address, port, timeout); | ||
| } | ||
|
|
||
| // NetconfSession::NetconfSession( |
| CHECK_NOTHROW(provider.get_capabilities()); | ||
| } | ||
|
|
||
| // TEST_CASE("CreateKeybaseAuthRepo_Domingo") |
| public_key_path = public, | ||
| port = self.port) | ||
|
|
||
| # private = "%s/domingo_sshkey" % dir_path |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.