Skip to content

Reduce python generated API file size#544

Merged
4 commits merged intomasterfrom
unknown repository
Sep 12, 2017
Merged

Reduce python generated API file size#544
4 commits merged intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Sep 11, 2017

  • Moved get_entity_path to entity_utils.hpp for C++
  • Introduced get_absolute_path to get absolute path to entity when required
  • Moved most of the generated ydk-python model API functions to static file py_types.py

Abhi Keshav added 2 commits September 11, 2017 14:50
 * Moved get_entity_path to entity_utils.hpp for C++
 * Moved most of the generated ydk-python model API functions to static
  file py_types.py
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 12, 2017

Codecov Report

Merging #544 into master will decrease coverage by 0.56%.
The diff coverage is 86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
- Coverage   79.71%   79.15%   -0.57%     
==========================================
  Files          95       91       -4     
  Lines        9462     9276     -186     
  Branches     1244     1269      +25     
==========================================
- Hits         7543     7342     -201     
- Misses       1661     1675      +14     
- Partials      258      259       +1
Impacted Files Coverage Δ
ydkgen/printer/__init__.py 100% <ø> (ø) ⬆️
ydkgen/printer/python/module_printer.py 81.13% <ø> (+6.13%) ⬆️
sdk/python/core/tests/test_sanity_delete.py 99.52% <ø> (ø) ⬆️
ydkgen/printer/python/class_printer.py 95.45% <ø> (+2.41%) ⬆️
ydkgen/builder/_api_model_builder.py 86.2% <0%> (ø) ⬆️
ydkgen/printer/cpp/class_members_printer.py 96.29% <100%> (+0.08%) ⬆️
ydkgen/printer/python/class_inits_printer.py 95.42% <100%> (-0.73%) ⬇️
ydkgen/printer/cpp/class_source_printer.py 98.43% <100%> (+0.03%) ⬆️
ydkgen/common.py 53.22% <100%> (+2.58%) ⬆️
sdk/python/core/ydk/entity_utils/__init__.py 100% <100%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5105ef9...4245869. Read the comment docs.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 12, 2017

Codecov Report

Merging #544 into master will decrease coverage by 0.55%.
The diff coverage is 87.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
- Coverage   79.71%   79.15%   -0.56%     
==========================================
  Files          95       91       -4     
  Lines        9462     9275     -187     
  Branches     1244     1269      +25     
==========================================
- Hits         7543     7342     -201     
- Misses       1661     1674      +13     
- Partials      258      259       +1
Impacted Files Coverage Δ
ydkgen/printer/__init__.py 100% <ø> (ø) ⬆️
sdk/python/core/tests/test_sanity_delete.py 99.52% <ø> (ø) ⬆️
ydkgen/builder/_api_model_builder.py 86.2% <0%> (ø) ⬆️
ydkgen/printer/python/module_printer.py 81.13% <100%> (+6.13%) ⬆️
ydkgen/printer/python/class_inits_printer.py 95.42% <100%> (-0.73%) ⬇️
ydkgen/printer/cpp/class_source_printer.py 98.43% <100%> (+0.03%) ⬆️
ydkgen/printer/python/class_printer.py 95.45% <100%> (+2.41%) ⬆️
sdk/python/core/ydk/entity_utils/__init__.py 100% <100%> (ø) ⬆️
ydkgen/common.py 53.22% <100%> (+2.58%) ⬆️
...dkgen/printer/cpp/class_get_entity_path_printer.py 82.97% <72.22%> (-13.38%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5105ef9...4b26d95. Read the comment docs.

@ghost ghost merged commit 6223e7f into CiscoDevNet:master Sep 12, 2017
@ghost ghost deleted the large_cpp_files_fix branch September 12, 2017 15:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants