Skip to content

Conversation

@gagern
Copy link
Member

@gagern gagern commented Jun 15, 2016

This avoids a bug with node 6.2.1 where the forbidden check will cause the following strange error:

_stream_readable.js:65
  // not happen before the first write call.

RangeError: out of range index
    at RangeError (native)
    at StringDecoder.fillLast (string_decoder.js:94:9)
    at StringDecoder.write (string_decoder.js:73:14)
    at readableAddChunk (_stream_readable.js:160:31)
    at ReadStream.Readable.push (_stream_readable.js:130:10)
    at onread (fs.js:1774:12)
    at FSReqWrap.wrapper [as oncomplete] (fs.js:675:17)

This change should be changed back once the problem has been analyzed and addressed in a better way.

This avoids a bug with node 6.2.1 where the forbidden check will cause the
following strange error:

    _stream_readable.js:65
      // not happen before the first write call.

    RangeError: out of range index
        at RangeError (native)
        at StringDecoder.fillLast (string_decoder.js:94:9)
        at StringDecoder.write (string_decoder.js:73:14)
        at readableAddChunk (_stream_readable.js:160:31)
        at ReadStream.Readable.push (_stream_readable.js:130:10)
        at onread (fs.js:1774:12)
        at FSReqWrap.wrapper [as oncomplete] (fs.js:675:17)

This change should be changed back once the problem has been analyzed and
addressed in a better way.
@kranich kranich merged commit 9119c02 into CindyJS:master Jun 15, 2016
@kranich
Copy link
Member

kranich commented Jun 15, 2016

@gagern Thanks.

@gagern
Copy link
Member Author

gagern commented Jun 15, 2016

I'm trying to bisect the node commits in question, but building node takes ages.

@gagern
Copy link
Member Author

gagern commented Jun 15, 2016

Bisected to nodejs/node@79ad172 for nodejs/node#6777. Not what I'd have expected. Reported nodejs/node#7308 about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants