🔍 Filter transactions based on graphqlOperationName#920
Merged
cortinico merged 7 commits intoDec 8, 2022
Merged
Conversation
graphqlOperationName
Contributor
Author
|
@cortinico Apologies if you're busy! Any idea when would you be able to review this PR? |
Member
I'll look into this over the weekend/next week 👍 |
cortinico
requested changes
Nov 26, 2022
cortinico
approved these changes
Dec 2, 2022
cortinico
left a comment
Member
There was a problem hiding this comment.
Let's add a small comment and is good to go for me 👍
vbuberen
approved these changes
Dec 7, 2022
vbuberen
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me as well. Thanks a lot for your contributions with GraphQL stuff!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📷 Screenshots
📄 Context
issue#847
📝 Changes
getFilteredTuplesin theHttpTransactionDao.ktwhich enables filtering on the basis ofGraphQLOperationName.In order to avoid any breaking changes the
pathQueryargument is utilized to filter on the basis ofgraphQLOperationName.I'm wondering if the argument name could be renamed to
filterQuery?HttpTransactionDatabaseRepositoryTest.kt&HttpTransactionDaoTest.kthave been updated📎 Related PR
🚫
🚫 Breaking
🚫
🛠️ How to test
DO HTTP ACTIVITY&DO GRAPHQL ACTIVITYLAUNCH CHUCKER ACTIVITYChucker should filter the transactions and display a GraphQL transaction with the operation name as
SearchCharacters⏱️ Next steps