Add support for Android 13#879
Closed
cortinico wants to merge 2 commits into
Closed
Conversation
This commit adds support for Android 13 with: - Bump of compileSdk to 33 - Bump of appcompat to 1.5.0 - Adding support for a `Chucker.requestNotificationPermission` util method to help users request the Notification permission. Apps that are already requesting such permission, should not use the method and Chucker will just work. Fixes #854 Closes #869
79cf20b to
8f410b1
Compare
Member
Author
|
FYI for everyone: We're holding on here as @vbuberen was also working on this (apologize for taking a stance at it) with a different approach on Permission request which we might want to merge instead 👍 |
Merged
Collaborator
|
Closing this one as #887 is merged already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📷 Screenshots
📄 Context
This commit adds support for Android 13 and add supports for requesting the notification permission.
📝 Changes
Chucker.requestNotificationPermissionutil method to help users request the Notification permission.Apps that are already requesting such permission, should not use the method and Chucker will just work.
📎 Related PR
Fixes #854
Closes #869
Closes #881
🛠️ How to test
Tested on an API 33 emulator. On Api <= 32 Chucker works correctly.
⏱️ Next steps
We might want to backport this to 3.x?