Skip to content

Fix strict mode threading issues#750

Merged
vbuberen merged 6 commits into
developfrom
fix/strict_mode
Dec 25, 2021
Merged

Fix strict mode threading issues#750
vbuberen merged 6 commits into
developfrom
fix/strict_mode

Conversation

@vbuberen

Copy link
Copy Markdown
Collaborator

📄 Context

This is a fix for #737. Seems like the issue was in accessing SharedPreferences from the main thread. We were not catching it earlier due to having not all StrictMode options enabled.
Added additional StrictMode checks to the sample app. Additionally saw that we still have a piece of code for removing Chuck database file. I suppose we don't need it anymore, so removed it.

📝 Changes

  • Added more StrictMode checks to the sample app.
  • Add dispatcher switching for doMaintanence() function to move from the main thread
  • Made prefs initialisation lazy, since it was also making StrictMode not happy before
  • Removed the code which tried to remove Chuck database
  • Updated Gradle wrapper to 7.3.2

🚫 Breaking

No breaking changes introduced

🛠️ How to test

Just run the sample app and see that no issues found with more StrictMode options enabled.

⏱️ Next steps

Closes #737

@vbuberen vbuberen added this to the 4.0.0 milestone Dec 25, 2021
@vbuberen

Copy link
Copy Markdown
Collaborator Author

P.S. Merry Christmas everyone 🎄 🎅🏻

@MiSikora MiSikora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! And Merry Christmas as well! 🎄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DiskRead and DiskWrite Violations in ChuckerCollector

2 participants