📄 Context

There is an issue – #487. While at first I was reluctant to fix it, because I didn't want to do some strange executor delegation inside closing to avoid talking to the database on the main thread, I actually checked the code today and all of the work can be delegated to Room.

📝 Changes

I made transactionUpdate() function suspending. This delegates internally in Room to Architecture Components executor. Additionally I fixed coroutine scopes. Previously we created a scope per request in collector or retention manager. Now they have their own scopes.

🚫 Breaking

No.

🛠️ How to test

Change ReadBytesCallback in the sample to something like this.

class ReadBytesCallback(
    private val byteCount: Long? = null,
) : Callback {
    override fun onFailure(call: Call, e: IOException) {
        e.printStackTrace()
    }

    override fun onResponse(call: Call, response: Response) {
        Handler(Looper.getMainLooper()).post {
            response.body?.source()?.use {
                try {
                    if (byteCount == null) {
                        it.readByteString()
                    } else {
                        it.readByteString(byteCount)
                    }
                } catch (e: IOException) {
                    e.printStackTrace()
                }
            }
        }
    }
}

It will crash with the original code. Now it behaves correctly.

⏱️ Next steps

Closes #487.