Skip to content

Add a shortcut when creating ChuckerInterceptor#588

Merged
vbuberen merged 13 commits into
ChuckerTeam:developfrom
Goooler:develop
Mar 26, 2021
Merged

Add a shortcut when creating ChuckerInterceptor#588
vbuberen merged 13 commits into
ChuckerTeam:developfrom
Goooler:develop

Conversation

@Goooler

@Goooler Goooler commented Mar 25, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Add a shortcut when creating ChuckerInterceptor for launch MainActivity like LeakCanary

screenshot

@Goooler

Goooler commented Mar 25, 2021

Copy link
Copy Markdown
Contributor Author

It seems api test failed, how can I solve it.

MiSikora
MiSikora reviewed Mar 25, 2021
View reviewed changes

@MiSikora MiSikora left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems api test failed, how can I solve it.

By making function you added internal or by executing apiDump Gradle task.

Comment thread library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated
Comment thread library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated
Comment thread library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated
Comment thread library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated
Comment thread library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated
Comment thread library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated
Comment thread library/src/main/java/com/chuckerteam/chucker/api/ChuckerInterceptor.kt Outdated
@vbuberen

vbuberen commented Mar 25, 2021

Copy link
Copy Markdown
Collaborator

I am curios if we need this feature before proceeding with the reviw.

@MiSikora

MiSikora commented Mar 25, 2021

Copy link
Copy Markdown
Contributor

Personally I like it. I won't fight for it, but I see it as a useful thing.

@Goooler Goooler requested a review from MiSikora March 26, 2021 02:41
@Goooler Goooler requested a review from vbuberen March 26, 2021 02:51
MiSikora
MiSikora reviewed Mar 26, 2021
View reviewed changes
Comment thread library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated
Comment thread library/src/main/java/com/chuckerteam/chucker/api/ChuckerInterceptor.kt Outdated
MiSikora
MiSikora reviewed Mar 26, 2021
View reviewed changes
Comment thread library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated
@Goooler Goooler requested a review from MiSikora March 26, 2021 06:58
MiSikora
MiSikora approved these changes Mar 26, 2021
View reviewed changes

@MiSikora MiSikora left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment, but other than that, LGTM. 🚀

Thank you for this contribution! I'll wait with merging for a second review/opinion.

You'll also need to execute apiDump Gradle task because a public function was added to the builder.

Comment thread library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated
@Goooler Goooler requested a review from MiSikora March 26, 2021 07:09
MiSikora
MiSikora reviewed Mar 26, 2021
View reviewed changes
Comment thread library/src/main/java/com/chuckerteam/chucker/api/Chucker.kt Outdated
@cortinico

cortinico commented Mar 26, 2021

Copy link
Copy Markdown
Member

I think this is a nice addition 👍
Should we add a note to the README?

@vbuberen

vbuberen commented Mar 26, 2021

Copy link
Copy Markdown
Collaborator

Should we add a note to the README?

I will take care of it in a follow-up PR for this feature.

@vbuberen vbuberen merged commit 664730a into ChuckerTeam:develop Mar 26, 2021
@vbuberen vbuberen mentioned this pull request Mar 26, 2021
Merged
@vbuberen vbuberen added the enhancement New feature or improvement to the library label Mar 26, 2021
@vbuberen vbuberen added this to the 4.0.0 milestone Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vbuberen vbuberen vbuberen approved these changes

+1 more reviewer

@MiSikora MiSikora MiSikora approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or improvement to the library

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Goooler @vbuberen @MiSikora @cortinico