Response processing refactor#554
Merged
Merged
Conversation
added 2 commits
February 9, 2021 19:25
Move response processing to a separate class
cortinico
approved these changes
Feb 9, 2021
Contributor
Author
|
Bumping because I don't want to get this message lost in a resolved comment. :) @cortinico Ok, I pushed the change in 007cd55 without the init block. Let me know which one you prefer more. I'm ok either way. |
Member
I'd go for the solution without the |
vbuberen
approved these changes
Feb 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Context
This is the final PR that is a result of splitting #527.
📝 Changes
Similarly to the
RequestProcessorclass I added theResponseProcessorclass that does the analogous stuff. I changed one thing, where plain text body is set to beplainText = trueonly when there is some content. I don't think it made sense to set it totruewhen there was no body.📎 Related PR
#527
🚫 Breaking
No.
🛠️ How to test
Rely on CI. Manually you can simply check the sample app.
⏱️ Next steps
N/A