Redact request headers in case of HTTP failures#545
Merged
Conversation
80bea25 to
fdcd06a
Compare
cortinico
approved these changes
Jan 30, 2021
vbuberen
approved these changes
Jan 31, 2021
vbuberen
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. Let's add note about this change to our changelog in unreleased section as well.
We should add it for other PRs with fixes/change as well.
Contributor
Author
Yeah, to be perfectly honest I totally forgot that it exists. Maybe we can add it as a comment in "Next steps" section that changes affecting users should be mentioned in the changelog? |
Member
Definitely 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Context
Request headers were not redacted if there were communication failures.
📝 Changes
Request headers are redacted also in a request processing pipeline.
📎 Related PR
#527
🚫 Breaking
No.
🛠️ How to test
I added unit tests.
⏱️ Next steps
This can wait with merging after #543 is resolved.