Conversation
MiSikora
reviewed
Oct 31, 2020
MiSikora
left a comment
Contributor
There was a problem hiding this comment.
Left one minor thing.
As far as the requests revamp go I think we should go with a similar route to responses processing.
MiSikora
approved these changes
Nov 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Context
There is an issue #472
Issue appears with StrictMode enabled. We couldn't catch the issue earlier, because sample app has no gzip request with body, so code with error wasn't reachable.
📝 Changes
use { }function to GzipSource ingetNativeSource()function.Buffer(), since Mockk can't properly react toclose()call.🛠️ How to test
To reproduce the issue remove
usefromgetNativeSource()and use just GzipSource directly. With StrictMode enabled sample will crash whenfakeGzipRequest()is called.⏱️ Next steps
We might want to improve the part of request processing and cover it with some more tests.
Closes #472