Enable transaction file sharing#451
Merged
Merged
Conversation
MiSikora
commented
Sep 16, 2020
9d7a95e to
a7bb5ec
Compare
This will allow to share binary data in the future.
1078b74 to
9c09e81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📷 Screenshots
📄 Context
There is an issue - #404.
📝 Changes
I added a way to share a single transaction as a file. I also refactored sharing flow.
ShareUtilsare removed in favour ofSharableinterface that is responsible for creating shared content that can be written to a file or wherever.Tests for sharing run now on Robolectric to use real resources instead of a mocked Context.
🚫 Breaking
No.
🛠️ How to test
Run the app and check sharing capabilities. Old ones should stay the same. Single file sharing should be available from transaction details.
⏱️ Next steps
Closes #404